Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: etherape - Graphical network monitor for Unix https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225604 ------- Additional Comments From wolfy@xxxxxxxxxxxxxxxxxx 2007-02-01 05:44 EST ------- Good - package meets naming guidelines - package meets packaging guidelines - license is GPL, text in %doc, matches source, includes COPYING from the sources - spec file legible, in am. english - source matches upstream, is last available version, sha1sum 72e5e570530a89ea962a17e55723318010e9a8e5 etherape-0.9.7.tar.gz - package compiles on devel (x86) and FC6 - no missing BR - MINOR: unnecessary BR libglade-devel (brought in by libgnomeui-devel) - handles locales properly - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - docs are small, but part of them are in scrollkeeper format (see below) - nothing in %doc affects runtime - no scriptlets - no static content - no pkgconfig(.pc) files - no libtool archives SHOULD - builds in mock on all tested platforms (FC6, devel, i386, x86_64) - runs OK on FC6/x86_64 MUSTFIX: - takes ownership of /usr/share/omf and /usr/share/pixmaps quire scrollkeeper - the desktop file is installed using --add-category X-Fedora which is no longer required (see PackagingGuidelines#desktop in the wiki) - part of the documentation requires scrollkeeper. I suggest one of the following two approaches -- either add scrollkeeper to Requires: or -- build a separate package for docs and make that package require scrollkeeper And a question: any other reason for not including the HTML pages except for the fact that in the source tarball they are available in both text and HTML format ? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review