Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=783073 Michael Scherer <misc@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misc@xxxxxxxx --- Comment #1 from Michael Scherer <misc@xxxxxxxx> 2012-03-24 15:23:42 EDT --- So now that diet is in, this one should be the next. - the license is not present in all cases. For exemple, if I install vishnu-ums-server, it just pull vshnu-core-server, and there is no license - the copying file is IMHO not sufficient, maybe you should bundle the rest in License/* - rm -rf $RPM_BUILD_ROOT is not needed in %install - I think you should use the %version in %setup and in $SOURCE0 - there is no url for Source0, nor any indication on where to get the source code - the servers do not need to be started by systemd ? - like diet, I assume the tests are not practical to run on koji/mock ? - I am sure that better description could help to understand what each packages do ( even if this is rather specialized ) - there is support for documentation created by doxygen, wouldn't that be useful to enable it ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review