Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=799702 Michael Scherer <misc@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misc@xxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |misc@xxxxxxxx Flag| |fedora-review? --- Comment #1 from Michael Scherer <misc@xxxxxxxx> 2012-03-24 13:30:21 EDT --- Hi, - the source code say that the code is under LGPL v3+ , so the license Tag need to be fixed ( it say GPLv3+ ). - there seems to be tests, have you tried to enable them in %check ? - %{_mandir}/man1/*.gz should not hardcode the extension, as this could change later ( like xz, bz2, etc ). Better use .* - rm -rf %{buildroot} is no longer needed in %install since a few version of Fedora. Once this is fixed, i will start the formal review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review