Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=718681 --- Comment #20 from Michael Schwendt <mschwendt@xxxxxxxxx> 2012-03-24 12:47:51 EDT --- A brief but hopefully helpful look at the spec file: > %package devel > Summary: Development files for %{name} > Group: System Environment/Libraries Library -devel packages typically are in group "Development/Libraries" whereas "System Environment/Libraries" is for the base library packages. > Requires: %{name} = %{version}-%{release} https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package > Requires: pkgconfig This can be removed because it is automatic. Take a look at the built rpms with "rpm -qpR ..." > %package static > Summary: Static library for %{name} > Group: System Environment/Libraries > Requires: %{name} = %{version}-%{release} Same here as above, plus: It makes no sense for the -static package to require the base package. If at all, it could require the -devel package. > %post devel -p /sbin/ldconfig > > %postun devel -p /sbin/ldconfig The are not needed for the -devel package. There is nothing in the -devel package that would be affected by running ldconfig. This is library base package stuff. > %files > %defattr(-,root,root,-) This %defattr is the default and need not be specified anymore: https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions > %{_datadir}/%{name}-%{version}/jit/* > %dir %{_datadir}/%{name}-%{version} > %dir %{_datadir}/%{name}-%{version}/jit Strange order of lines. Due to the '*' wildcard, you could reduce these three lines to just %{_datadir}/%{name}-%{version}/ to include that directory and everything in it properly. > %dir %{_libdir}/lua > %dir %{_libdir}/lua/5.1 > %dir %{_datadir}/lua > %dir %{_datadir}/lua/5.1 Empty directories so far. Intentional? If so, a comment in the spec file would be appropriate. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review