Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=707720 Michael Scherer <misc@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misc@xxxxxxxx --- Comment #5 from Michael Scherer <misc@xxxxxxxx> 2012-03-24 04:06:34 EDT --- Hi, can you update the package to the latest release so we can start the review ? Also, : - Buildroot should be removed, as this is no longer needed - %doc should include the license ( and so you should ask upstream to ship the license ) - rm -rf %{buildroot} in beggining of %install, %defattr and %clean are uneeded for latest fedora and more important, it seems the module is not compiled in fedora 16 kernel :/ ( not blocking for review, but annoying for testing and usage, so I would suggest asking to have it enabled ). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review