Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=737972 Michael Scherer <misc@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misc@xxxxxxxx --- Comment #1 from Michael Scherer <misc@xxxxxxxx> 2012-03-24 03:28:04 EDT --- Hi, can you update the spec file for the latest release ( and the tarball for the version 1.6.X are missing ) ? also, a few note : - for a fedora rpm, BuildRoot is no longer needed, same goes for %defattr, and %clean, and cleaning of %install - you should use %global, not %define for %rhnroot http://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define - you should consider using packages rather than filedesps, for reasons listed in the guideline : http://fedoraproject.org/wiki/Packaging:Guidelines#File_Dependencies - you should also ( IMHO ) place requires on 1 line each, as it permit to have easier to read diff when sending patch - the file spacewalk-service look like a init script, and recent fedora use systemd, so the file should be converted http://fedoraproject.org/wiki/Packaging:Systemd -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review