Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=798202 Michael Scherer <misc@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misc@xxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |misc@xxxxxxxx Flag| |fedora-review? --- Comment #1 from Michael Scherer <misc@xxxxxxxx> 2012-03-24 02:40:42 EDT --- Is the package for EPEL ? ( as there is BuildRoot and %clean ) Also : - BuildRequires on python-devel should say what version of python need to be used http://fedoraproject.org/wiki/Packaging:Python#BuildRequires - the license should be in %doc, and since there is no lincese upstream, you should ask upstream to add it - the snippet for %python_sitelib is likely uneeded ( unless need to be pushed to EPEL ) - there is no %dist in the release - if the source cannot be downloaded, packager should give instruction on how to do it http://fedoraproject.org/wiki/Packaging:SourceURL#Troublesome_URLs - there is no %check to run the tests - the source code speak of having a license GPL or LGPL or MPL, so triple license. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review