Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=806446 Michael Scherer <misc@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misc@xxxxxxxx --- Comment #1 from Michael Scherer <misc@xxxxxxxx> 2012-03-23 17:42:44 EDT --- Hi, a few comments : - you should add a note for the patch ( ie, say if it come from upstream or not, https://fedoraproject.org/wiki/Packaging:Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment - Provides: minutunes%{?_isa} = %{version}-%{release} I am not sure about adding the {?_isa} part, as the whole idea of adding the provides is to help someone typing "yum install minitunes". I think that's rather unconventional, and maybe not useful. - there is a typo, this is minitunes, not minutunes ( in the provides lines ) - BuildRequires: qt-devel taglib-devel phonon-devel gcc-c++ it is IMHO better to have 1 line for each buildRequires, since this produce better diff, and so allow to review patches more easily. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review