Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=806299 --- Comment #3 from Praveen Kumar <kumarpraveen.nitdgp@xxxxxxxxx> 2012-03-23 14:56:35 EDT --- > rpmlint python-django-registration-0.7-4.fc18.src.rpm > > python-django-registration.src: W: spelling-error %description -l en_US signups > -> sign ups, sign-ups, signposts > python-django-registration.src: W: invalid-url Source0: Done > See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint > [!]: MUST Sources used to build the package match the upstream source, as > provided in the spec URL. > /home/mrunge/review/806299/django-registration-0.7.tar.gz : > MD5SUM this package : 5c92e93a699905dce2e3f59285013b0a > MD5SUM upstream package : d41d8cd98f00b204e9800998ecf8427e On pypi md5sum of the package is 5c92e93a699905dce2e3f59285013b0a one only, I didn't know from where you got a different md5sum of source? > > See: http://fedoraproject.org/wiki/Packaging/SourceURL > > - Please correct upstream url: > http://pypi.python.org/packages/source/d/%{name}/%{pkgname}-%{version}.tar.gz > must be > http://pypi.python.org/packages/source/d/%{pkgname}/%{pkgname}-%{version}.tar.gz Done > - please use python2-devel instead of python-devel > cf. https://fedoraproject.org/wiki/Packaging:Python#BuildRequires > > - you should hardcode the obsoletes-version > cf. https://fedoraproject.org/wiki/User:Bkabrda/Django_rename#Django-foo > Done > - CFLAGS should be dropped from build. This package is noarch. Done > - rm -rf ... should be dropped from install-section. We're only targeting f18 > and later. Done Spec URL: http://kumarpraveen.fedorapeople.org/registration/python-django-registration.spec SRPM URL: http://kumarpraveen.fedorapeople.org/registration/python-django-registration-0.7-5.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review