[Bug 611372] Review Request: perl-Net-Twitter - Perl interface to Twitter

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=611372

--- Comment #14 from Petr Šabata <psabata@xxxxxxxxxx> 2012-03-23 05:49:29 EDT ---
(In reply to comment #13)
> (In reply to comment #12)
> 
> Hi Petr,
> 
> I think I've fixed all these problems, and I have one question before asking
> for a re-review. To your last point about whether the package needs specific
> versions of runtime libraries: Is that something that I should infer from the
> software's Makefile.PL? The actual code doesn't "use" any particular versions
> of the libraries upon which it depends.

Well, that depends.  You should always inspect the code, the project
Makefile.PL/Build.PL and META.* files before you decide.

In this case, LWP::UserAgent 5.819 is used in tests so it should be
buildrequired instead of 2.032 specified in Makefile.PL (and META.yml).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]