[Bug 803350] Review Request: python-django-simple-captcha - Django application to add captcha images to any Django form

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=803350

--- Comment #3 from Matthias Runge <mrunge@xxxxxxxxxxxxxxxxx> 2012-03-23 04:46:24 EDT ---
Thank you for the review. I corrected the issues, updated URLs at the bottom.


[mrunge@sofja SPECS]$ diff -u python-django-simple-captcha.spec-2
python-django-simple-captcha.spec
--- python-django-simple-captcha.spec-2 2012-03-14 14:52:16.000000000 +0100
+++ python-django-simple-captcha.spec 2012-03-23 09:40:15.365177512 +0100
@@ -4,7 +4,7 @@
 Summary: Django application to add captcha images to any Django form
 Name:  python-django-simple-captcha
 Version: 0.3.0
-Release: 2%{?dist}
+Release: 3%{?dist}
 License: MIT
 Group:  Development/Libraries
 URL:  http://code.google.com/p/django-simple-captcha/ 
@@ -15,6 +15,8 @@
 BuildRequires: python-setuptools 
 BuildRequires: gettext

+Requires:  python-django
+
 Provides:  %{pkgname} = %{version}-%{release}
 Obsoletes:  %{pkgname} < %{obs_ver}

@@ -35,24 +37,23 @@
 %install
 %{__python} setup.py install -O1 --skip-build --root="%{buildroot}"
--prefix="%{_prefix}"

-# Handling locale files
-# This is adapted from the %%find_lang macro, which cannot be directly
-# used since Django locale files are not located in %%{_datadir}
-#
-# The rest of the packaging guideline still apply -- do not list
-# locale files by hand!
-(cd $RPM_BUILD_ROOT && find . -name 'django*.mo') | %{__sed} -e 's|^.||' |
-%{__sed} -e \
-   's:\(.*/locale/\)\([^/_]\+\)\(.*\.mo$\):%lang(\2) \1\2\3:' \
-   >> %{pkgname}.lang
+# copy language files
+# reported isssue upstream
+# http://code.google.com/p/django-simple-captcha/issues/detail?id=60
+mkdir -p %{buildroot}/%{python_sitelib}/captcha/locale/fr/LC_MESSAGES
+cp -p captcha/locale/fr/LC_MESSAGES/django.?o
%{buildroot}/%{python_sitelib}/captcha/locale/fr/LC_MESSAGES

+%find_lang django

-%files -f %{pkgname}.lang
+%files -f django.lang
 %doc LICENSE MANIFEST.in PKG-INFO
 %{python_sitelib}/captcha/
 %{python_sitelib}/django_simple_captcha-%{version}-py2*

 %changelog
+* Fri Mar 23 2012 Matthias Runge <mrunge@xxxxxxxxxxxxxxxxx> - 0.3.0-3
+- minor spec cleanup
+
 * Wed Mar 14 2012 Matthias Runge <mrunge@xxxxxxxxxxxxxxxxx> - 0.3.0-2
 - rename package to python-django-simple-captcha


Updated SPEC:
http://www.matthias-runge.de/fedora/python-django-simple-captcha.spec
Updated SRPM:
http://www.matthias-runge.de/fedora/python-django-simple-captcha-0.3.0-3.fc17.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]