[Bug 804826] Review Request: ipxe - A network boot loader

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=804826

--- Comment #3 from Michael Scherer <misc@xxxxxxxx> 2012-03-22 20:08:14 EDT ---
Sorry for not looking earlier.

There is lots of file without any copyright, and the FSF address is wrong in
the other, so can you notify upstream about this ? 


Since that's just a fork and a rereview, and this was ok before, that's likely
ok too, but I think that should be corrected ( since as spot say on
http://spot.livejournal.com/303000.html "Get your licensing right, the first
time. You really do not know where your code will end up." ).


You also forgot to remove %defattr from 2 packages, so can you remove them on
import ?

I am posting the review on next comment.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]