Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=805332 Michael Scherer <misc@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misc@xxxxxxxx --- Comment #1 from Michael Scherer <misc@xxxxxxxx> 2012-03-22 12:06:30 EDT --- Hi, a few comment : - why %doc without any doc ? - you requires python, but I think you need to tell the version ( 2 or 3 ) - BuildRoot is uneeded, unless you plan to support epel 5 ( if you need to do so, there is then others stuff, like %clean section, etc ) and there is no license at all in the source code ( nor shipped as part of a tarball, since there is no tarball ), which is a blocking point : https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review