Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=802758 Brett Lentz <brett.lentz@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+ --- Comment #4 from Brett Lentz <brett.lentz@xxxxxxxxx> 2012-03-21 10:06:48 EDT --- $ rpmlint drupal6-drush-4.1-3.fc16.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Overall, it looks like there's no major issues. This package is approved. Some recommendations before you do the first build: I'd recommend removing the comments in the %files section from the spec template. Second, if Drush is a CLI tool, it would make sense to install the executable or a symlink into %bindir, rather than having it in %datadir. This CLI tool also doesn't ship with any man pages. Please work with upstream to get some created, as all executables SHOULD have man pages. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review