Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=788569 --- Comment #2 from Tomáš Bžatek <tbzatek@xxxxxxxxxx> 2012-03-20 14:11:01 EDT --- > BuildRequires: unique-devel >= 1.1.6 Shouldn't this be unique3 rather? Also, configure.ac references no libunique, is that really necessary? > BuildRequires: gnome-keyring-devel > BuildRequires: libgnome-keyring-devel Duplicate BR, only use libgnome-keyring-devel > BuildRequires: libtool automake autoconf Not needed probably, I don't see any traces of automake files modifications Explicit require of libgcrypt-devel would be nice, it's referenced from configure as well. > BuildRequires: gtk-doc scrollkeeper intltool gettext flex bison perl(XML::Parser) Are flex and bison really necessary? Note: some header files in the -devel package reference header files which should ideally belong to plugins. Let's keep them all in the common -devel package. Note: builds fine in koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3914490 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review