Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=804826 Michael Scherer <misc@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misc@xxxxxxxx --- Comment #1 from Michael Scherer <misc@xxxxxxxx> 2012-03-20 12:39:09 EDT --- A few comments before starting the review : - use %global rather than %define ( see https://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define ) - BuildRoot is no longer needed and should be removed - same for rm -rf $RPM_BUILD_ROOT at the beggining of %install, and for %clean - %defattr(-,root,root,-) is uneeded too - Patch1 should have a mention of being sent upstream - BuildRequires would be IMHO, better on a 4 lines, better for reviewing diff ( but that's just a personal note, not blocking for review ) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review