Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=803082 Mario Blättermann <mario.blaettermann@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #3 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> 2012-03-19 21:16:04 EDT --- (In reply to comment #2) > Hi, > > A few comments : > - desktop-file-validate %{buildroot}/%{_datadir}/applications/%{name}.desktop > > If you use $RPM_BUILD_ROOT, you should use it here too, ot use %{buildroot} in > the beginning > > https://fedoraproject.org/wiki/Packaging:Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS > Fixed. > > - %%doc COPYING NEWS README > Is this normal to have %% instead of % ? > No, it's a mistake ;) I've removed the duplicate percent sign. > - the patch comment should have a link to upstream bug report, and explain more > why it is needed. > > https://fedoraproject.org/wiki/Packaging:Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment > Added some more info and a link to the appropriate Bazaar commit. > - I am not sure that mentioning en %description file formats not supported out > of the box ( per licensing reason ) is a good idea. This is kinda misleading. Yes, you are right. Without package repos such as Rpmfusion the mp3 playback won't work. I've removed this sentence. New files: Spec URL: http://mariobl.fedorapeople.org/Review/SPECS/pogo.spec SRPM URL: http://mariobl.fedorapeople.org/Review/SRPMS/pogo-0.5-2.fc16.src.rpm Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3911671 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review