Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=790628 --- Comment #29 from Alec Leamas <leamas.alec@xxxxxxxxx> 2012-03-19 14:38:43 EDT --- (In reply to comment #28) > It is much better now. Yup. Thanks to you [cut] > adobe-source-libraries-doc.x86_64: E: zero-length > /usr/share/doc/adobe-source-libraries-doc-1.0.43/documentation/performance/index.html > > Please query upstream about this file, also nice to have: [ -s > documentation/performance/index.html ] || rm -f > documentation/performance/index.html Fixed, link in spec. > [?]: MUST Changelog in prescribed format. > It seems not to be against the guidelines, but the changelog from example > differs: > http://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs > So I would prefer not using the space indentation for version-release suffix > and also not inserting VIM metadata in the end of SPEC file (# vim: > tabstop=4:expandtab). It's just kind of a habit, and the two other packages I own have this layout. They where reviewed by my sponsor, and he accepted as soon he understood it was on purpose. But if you insist, I will of course remove the whitespace. The vim metadata is removed > [!]: MUST Package consistently uses macros (instead of hard-coded directory > names). > $RPM_BUILD_ROOT is used, according to other vars/macros usage %{buildroot} > should be used instead. Fixed > [!]: MUST Sources used to build the package match the upstream source, as [cut] > Please use sourceforge URL as noted in: > http://fedoraproject.org/wiki/Packaging:SourceURL#Sourceforge.net Fixed. The reference URL doesn't work, I tried to stay as close as possible. > [!]: SHOULD SourceX / PatchY prefixed with %{name}. [cut] > Not blocker, nice to have. and prefixing w adobe-source-libraries instead of asl would give insanely long names... > > Other: > For adobe-source-libraries-doc package, I would rather see the doc in > /usr/share/doc/adobe-source-libraries-1.0.43 directory instead of > /usr/share/doc/adobe-source-libraries-doc-1.0.43 Yet another good spot. Fixed. New links: http://dl.dropbox.com/u/17870887/adobe-7/adobe-source-libraries.spec http://dl.dropbox.com/u/17870887/adobe-7/adobe-source-libraries-1.0.43-7.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review