Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=800526 --- Comment #2 from Rui Matos <tiagomatos@xxxxxxxxx> 2012-03-19 13:07:08 EDT --- Thanks for the review! (In reply to comment #1) > - %{_datadir}/pixmaps/seahorse/*/seahorse-share-keys.* > this will create unowned directory, this should be corrected ( I think ) Should be fixed now. > - there is libegg bundled, and so this requires to have a specific provides : > > https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries#Packages_granted_exceptions Does this make sense when there's no "official" libegg.so on the filesystem provided by any package? Consumers of this library usually just use some files from it and statically link them into their binaries. From a quick glance at both evince.spec and eog.spec neither lists this bundled(egglib) Provides although both use libegg files. I also updated to the latest release: Spec URL: http://glua.ua.pt/~rmatos/seahorse-sharing.spec SRPM URL: http://glua.ua.pt/~rmatos/seahorse-sharing-3.3.92-1.fc16.src.rpm http://koji.fedoraproject.org/koji/taskinfo?taskID=3910422 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review