Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=799896 --- Comment #4 from Cédric OLIVIER <cedric.olivier@xxxxxxx> 2012-03-16 14:02:10 EDT --- Thanks for this update, you can find now my review : [+] mock build OK [+] source files match upstream d9d3198e464d0cb89aa94d18696c4d0e [+] package name according to the Package Naming Guidelines [+] specfile is properly named, is cleanly written and uses macros consistently. [+] dist tag is present. [+] license field matches the actual license. [+] license is open source-compatible. MIT [+] license text included in package. [+] latest version is being packaged. [+] BuildRequires are proper. [+] compiler flags are appropriate. [+] handle locales properly [+] package installs properly [NA] debuginfo package looks complete. [+] rpmlint is silent. [+] no shared libraries are added to the regular linker search paths. [+] owns the directories it creates. [+] doesn't own any directories it shouldn't. [+] no duplicates in %files. [+] file permissions are appropriate. [+] scriptlets are present and sane. [+] documentation is small, so no -docs subpackage is necessary. [NA] GUI applications must include a %{name}.desktop [NA] contain man pages for binaries/scripts Approved -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review