Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=799089 William Cohen <wcohen@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|needinfo?(wcohen@xxxxxxxxxx | |) | --- Comment #4 from William Cohen <wcohen@xxxxxxxxxx> 2012-03-15 17:30:36 EDT --- MUST: packaging guidelines: - bundled librares, as below - make DESTDIR=%{buildroot} should work ( DESTDIR=... isn't currently honored in the make) - %configure should be used (agreed, tried to use %configure, but because of the intermixed build/ install. the build would attempt to install in /usr/lib and /usr/include because it ignored the staged installs, if is DESTDIR honored, might be able to use %configure) MUST: not bundle system libraries - boost is bundled, and is even installed into dyninst-devel. (it looks like one can just add a BuildReqs: boost-deve and nuke the boost subdirectory) ReviewGuidelines SHOULD items failed: /usr/bin/parseThat should have a man page -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review