Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=784605 Martin Preisler <mpreisle@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #4 from Martin Preisler <mpreisle@xxxxxxxxxx> 2012-03-14 09:44:02 EDT --- You are probably right regarding noarch. Also the binary blob I was talking about is just the infamous waf self extracting part and while it's horrible, it's also acceptable with current policy. regarding rpmlint messages: * no-binary is safe to ignore in this case * the dangling symlink as well OK matches upstream tarball OK naming guidelines OK Fedora approved license OK license matches upstream OK package builds OK permissions OK spec file clean and legible, OK no desktop file OK owns all directories it creates The package is very similar to lv2-ui which has already been approved. Looks like hdegoede did most of the work for me and you applied all that to this package :-D APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review