Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=801092 --- Comment #8 from Martin Preisler <mpreisle@xxxxxxxxxx> 2012-03-14 08:18:38 EDT --- I tried to address all issues, hopefully I haven't missed anything. Thanks everyone for comments! Spec URL: http://mpreisle.fedorapeople.org/pkgs/sumwars/sumwars.spec SRPM URL: http://mpreisle.fedorapeople.org/pkgs/sumwars/sumwars-0.5.6-2.fc16.src.rpm Changes: * added Amusements/Games group to the base package * cmake flags -DSUMWARS_NO_TINYXML:BOOL=ON and -DSUMWARS_NO_ENET:BOOL=ON added (use system wide tinyxml and enet), added -devel packages of these to BuildRequires * snippet from Brendan Jones that deals with encoding of AUTHORS in %prep Regarding CMAKE_BUILD_TYPE, I am using the upstream default RelWithDebInfo to get a release build with debug info, debug info is stripped to -debug subpackage. Copyright: * /tools/{meshtest,graphicengine}/Example* - this sample code is public domain, I have asked if it's even used in sumwars, could be just leftover * ./share/resources/gui/imagesets/TaharezLook.tga is a derivate of CEGUI stock datafile, it's CC-BY-SA only in sumwars * ./src/core/nlfg.h - I listed MIT in Licenses * I am not sure what to do about the Find*.cmake modules, they are used all over the place, does everyone list BSD just because of this? Mutual dependency is intentional. Fixed the desktop file with suggestions given above, I will suggest upstream to adopt this. I am removing OgreCore.zip after install, it is not used according to resources.cfg Instead of using the bundled DejaVu fonts I am removing them and installing symbolic links (also added dejavu-{sans,serif}-fonts to Requires). The errorchecker.py script would be great but it checks for everything in the same folder as the executable is, wouldn't work for this scenario. rpmlint output changed for sumwars-data: $ rpmlint ~/rpmbuild/RPMS/noarch/sumwars-data-0.5.6-2.fc16.noarch.rpm sumwars-data.noarch: W: no-documentation sumwars-data.noarch: W: dangling-symlink /usr/share/sumwars/resources/gui/fonts/DejaVuSerif.ttf /usr/share/fonts/dejavu/DejaVuSerif.ttf sumwars-data.noarch: W: dangling-symlink /usr/share/sumwars/resources/gui/fonts/DejaVuSans.ttf /usr/share/fonts/dejavu/DejaVuSans.ttf -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review