[Bug 750898] Review Request: icaro - A robot automation language

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=750898

Ralf Corsepius <rc040203@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rc040203@xxxxxxxxxx

--- Comment #7 from Ralf Corsepius <rc040203@xxxxxxxxxx> 2012-03-14 03:02:42 EDT ---
2 nits:

* %release is poorly chosen. It needs to contain a fedora specific release
number.
You are trying to reuse some upstream release number, which doesn't leave the
fedora package maintainer an option to increment it.

* Please move the "chmod -x" from %build into %prep.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]