Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=794715 --- Comment #7 from Juan Hernández <juan.hernandez@xxxxxxxxxx> 2012-03-13 16:53:41 EDT --- Package Review ============== Key: - = N/A x = Check ! = Problem ? = Not evaluated === REQUIRED ITEMS === [!] Rpmlint output: $ rpmlint commons-ognl-3.0.2-1.fc17.src.rpm commons-ognl.src: W: invalid-url Source0: commons-ognl-3.0.2.tar.xz 1 packages and 0 specfiles checked; 0 errors, 1 warnings. Can't check binary packages as build fails. [!] Package is named according to the Package Naming Guidelines[1]. As pointed out by Alexander Kurtakov other packages from Apache commons are named apache-commons-whatever, so this one should be apache-commons-ognl. Being a post release the version and release tags should be: 3.0.2-1.20120313svn1102435 [x] Spec file name must match the base package name, in the format %{name}.spec. [x] Package meets the Packaging Guidelines[2]. [!] Package successfully compiles and builds into binary rpms. See http://koji.fedoraproject.org/koji/taskinfo?taskID=3891615. The relevant error is the following in build.log: The repository system is offline but the artifact net.java.dev.jna:jna:jar:3.2.2 is not available in the local repository. This can be resolved adding "BuildRequires: jna". [x] Buildroot definition is not present [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines[3,4]. [x] License field in the package spec file matches the actual license. License type: ASL 2.0 [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x] All independent sub-packages have license of their own [x] Spec file is legible and written in American English. [x] Sources used to build the package matches the upstream source, as provided in the spec URL. MD5SUM this package : 33b6d3507a5fd8e952c6d156b891d022 MD5SUM upstream package: ee9905892d509ef4bf2cec826eaa2fa3 Compared the sources in this package with the upstream sources using diff and there is no difference. [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines[5]. [x] Package must own all directories that it creates or must require other packages for directories it uses. [x] Package does not contain duplicates in %files. [x] File sections do not contain %defattr(-,root,root,-) unless changed with good reason [x] Permissions on files are set properly. [x] Package does NOT have a %clean section which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). (not needed anymore) [x] Package consistently uses macros (no %{buildroot} and $RPM_BUILD_ROOT mixing) [x] Package contains code, or permissable content. [-] Fully versioned dependency in subpackages, if present. [-] Package contains a properly installed %{name}.desktop file if it is a GUI application. [-] Package does not own files or directories owned by other packages. [x] Javadoc documentation files are generated and included in -javadoc subpackage [x] Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlinks) [x] Packages have proper BuildRequires/Requires on jpackage-utils [x] Javadoc subpackages have Require: jpackage-utils [x] Package uses %global not %define [x] If package uses tarball from VCS include comment how to re-create that tarball (svn export URL, git clone URL, ...) [-] If source tarball includes bundled jar/class files these need to be removed prior to building [-] All filenames in rpm packages must be valid UTF-8. [x] Jar files are installed to %{_javadir}/%{name}.jar (see [6] for details) [x] If package contains pom.xml files install it (including depmaps) even when building with ant [x] pom files has correct add_maven_depmap === Maven === [x] Use %{_mavenpomdir} macro for placing pom files instead of %{_datadir}/maven2/poms [-] If package uses "-Dmaven.test.skip=true" explain why it was needed in a comment [-] If package uses custom depmap "-Dmaven.local.depmap.file=*" explain why it's needed in a comment [x] Package DOES NOT use %update_maven_depmap in %post/%postun [x] Packages DOES NOT have Requires(post) and Requires(postun) on jpackage-utils for %update_maven_depmap macro === Other suggestions === [x] If possible use upstream build method (maven/ant/javac) [x] Avoid having BuildRequires on exact NVR unless necessary [x] Package has BuildArch: noarch (if possible) [!] Latest version is packaged. Version in the package is revision 1239219 and latest in the upstream repository is 1102435. [!] Reviewer should test that the package builds in mock. Tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=3891615 === Issues === 1. The rpmlint warning about the URL is acceptable. 2. The name should be "apache-commons-ognl". 3. The "version-release" tags should be "3.0.2-1.20120313svn1102435". 4. The package does not build in Koji, it is missing "BuildRequires: jna". 5. This is not the latest version, but it has been already discusssed and agreed in the bug that it is acceptable and correct to package this version. === Final Notes === 1. Issues #2, #3 and #4 need to be fixed. Once that is done I will continue the review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review