Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=773011 --- Comment #1 from Jon Ciesla <limburgher@xxxxxxxxx> 2012-03-13 16:27:52 EDT --- Good: - rpmlint checks return: api-sanity-checker.src: W: summary-ended-with-dot C An automatic generator of basic unit tests for a shared C/C++ library. Summary ends with a dot. Fix. api-sanity-checker.src: W: invalid-url URL: http://forge.ispras.ru/projects/api-sanity-autotest <urlopen error timed out> The value should be a valid, public HTTP, HTTPS, or FTP URL. Worked for my browser. api-sanity-checker.noarch: W: no-manual-page-for-binary api-sanity-checker Each executable in standard binary directories should have a man page. If available. - package meets naming guidelines - package meets packaging guidelines X license ( ) OK, text in %doc, matches source Should be GPLv2 or LGPLv2, I think. - spec file legible, in am. english - source matches upstream - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file Otherwise, it looks good. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review