Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=801092 --- Comment #6 from Martin Erik Werner <martinerikwerner@xxxxxxxxx> 2012-03-13 06:35:29 EDT --- Whoops, sorry I glossed over your comment about the desktop file when writing my review comments before. But still, it might make sense to use the upstream versions, since if translations etc. are incorporated there it would allow fedora to easily incorporate them.. I'm not sure about this, but I don't think the TryExec: is really necessary, since the only thing it will do is hide the entry unless it finds this file, I think it might be worth removing, and that plus only using 'sumwars' as the Exec: would make the desktop file non-path-dependent and cross-distro... You might want to suggest this to upstream to allow them to install the desktop file in the install phase? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review