Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=790805 --- Comment #4 from adev <adev88@xxxxxxxxx> 2012-03-13 05:03:18 EDT --- Is there a particular reason for this Provides in the python subpackage? Provides: %{name}-py%{python_version_nodot} = %{version} -> Yes, it is a compatibility with the European project EMI. Similars things for the other EMI components ( Lcgdm, lfc, gfal ) have already been added to EPEL/fedora. You can remove automake from the BuildRequires list, it's already required by libtool and voms-devel. -> done You *MUST* use the %configure macro, instead of calling explicitely the ./configure script: - the macro sets the appropriate CFLAGS/CXXFLAGS to build the program - it already set most of the options you pass to configure -> done, sorry for this.. the copy/paste kills the little cats. * --enable-debug → the debug flags are already in RPM_OPT_FLAGS * --enable-wall → already in RPM_OPT_FLAGS too -> removed, too. * --with-pythonrelease=%{python_version} → the ./configure script is able to find the defaut Python version/libs * --with-version=%{version} / --with-release=%{release} → do you really need to set explicitely the version of lcg-util at build time? This is all but robust. -> This is needed by the upstream, this software is included in differents project that are not EPEL related and this flags are still needed in these one. I upload the updated version as soon as possible -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review