[Bug 802377] Review Request: perl-Env-Sanctify - Lexically scoped sanctification of %ENV

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=802377

--- Comment #2 from Paul Howarth <paul@xxxxxxxxxxxx> 2012-03-12 10:11:09 EDT ---
(In reply to comment #1)
> TODO: There are some missing build dependencies (required by bundled
> Module::Install), namely base, Cwd, File::Path, and File::Spec.  The package
> builds without them at the moment, though.

Added in -2.

> NOTE: I guess you're going to maintain EPEL branches as well so the usual
> BuildRoot/%defattr/%clean stuff is okay.

Indeed, although since EL-4 is now EOL I'm leaving out %defattr as that's not
been needed since before rpm version 4.4.

> TODO: Incorrent FSF address in the licence. Notify upstream, please.

Done: https://rt.cpan.org/Ticket/Display.html?id=75714

> No blockers.  Approving.

Thanks Petr.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]