Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=760154 --- Comment #2 from Mohamed El Morabity <pikachu.2014@xxxxxxxxx> 2012-03-12 09:14:05 EDT --- - You can remove the BuildRoot tag: https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag - The BuildRequires on pkgconfig is useless, since xcb-util-devel already requires it. - You can also remove the Requires on pkgconfig in the devel subpackage, since it provides a pc. file. A dependency on pkgconfig is automatically added. - You can remove the « rm -rf %{buildroot} » instruction in %install: https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag - %defattr is no longer needed in %files: https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions - About the rpath issue... I tried to build your source RPM in F16 (x86_64), without the rpath fix stuff... The package can be built. Is the rpath fixes are really useful? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review