[Bug 799810] Review Request: python-picloud - PiCloud client-side Library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=799810

--- Comment #10 from Volker Fröhlich <volker27@xxxxxx> 2012-03-11 13:22:01 EDT ---
Please look at these examples:

http://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs

Your format is the one without the dash, but you're missing the release number.

* Fri Mar 9 2012 Amit Saha <amitksaha@xxxxxxxxxxxxxxxxx> 2.4.2

should be

* Fri Mar 9 2012 Amit Saha <amitksaha@xxxxxxxxxxxxxxxxx> 2.4.2-2

%{_bindir}/ must be %{_bindir}/*, otherwise you're trying to own /usr/bin.

You could also consider to patch setup.py. That'd get you rid of the error
message while installing and you don't have to install manpage and bash
completion file on your own.

On second thoughts: The bash completion should probably not be considered
configuration at all. I looked through a couple of bash completion files (yum,
mock, git, bash-completion) and none of them labels it as configuration. I
guess you should do the same.

rpm -qf /etc/bash_completion.d/mock.bash
rpm -qc mock
...

If you incorporate these changes, the package is pretty fine from my point of
view. Nevertheslles I can't take the review, because you need a sponsor.

For the reviewer: The package now builds in Mock.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]