Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=799810 --- Comment #7 from Amit Saha <amitsaha.in@xxxxxxxxx> 2012-03-09 09:43:16 EST --- (In reply to comment #3) > It's not LGPLv2 but LGPLv2+. APL 2.0 and LGPLv2 are not compatible, as far as I > can see, so you should mention both, as you do. But the three clause BSD > without advertising that src/util/cronexpr.py has, is compatible with GPL. So i > think the overall license should be LGPLv2+ and ASL 2.0. > > Use the macros with mkdir as well! > > Remove the Requires for Python at all. > > What is it about this comment: > # These packages are not require for python >=2.6 but required for python = 2.5 > > I'm getting two warnings: > > #Warning: Could not install bash completion scripts due to [Errno 13] > Permission denied: '/etc/bash_completion.d/picloud' > #Warning: Could not install bash completion scripts due to [Errno 13] > Permission denied: '/usr/share/man/man1/picloud.1' > > The last line in the files section should be something like: > > %config(noreplace) %{_sysconfdir}/bash_completion.d/* > > Otherwise you'll own /etc and /etc/bash_completion. Why do you feel this should > be "(noreplace)"? It is not something users usually customize, or is it? > > The package still doesn't build in Mock. Can you please take a look at the current SPEC and SRPM? Thanks for your comments! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review