Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=722713 --- Comment #18 from Volker Fröhlich <volker27@xxxxxx> 2012-03-08 15:25:54 EST --- README: "pyACE is free software: you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation, either version 3 of the License, or (at your option) any later version. ... http://code.google.com/p/curvatura/ " Spec file: GPLv2+ http://curvatura.googlecode.com/ pyace.noarch: W: incoherent-version-in-changelog 3.2 ['3.0-2.fc16', '3.0-2'] The examples should be labeled documentation. It is common to put the documentation first in the files section. The manpage should rather be %{_mandir}/man1/pyace.1* Please use the name macro consistently, meaning don't switch between %{name} and pyace. I think it'd be better to have %{python_sitelib}/%{name}-%{version}-py*.egg-info instead of a specific Python version. I'd write .py* instead of .py, .pyc and .pyo, but it's not a blocker. There's a lot of slack in the tarball, by the way: - rpms and tarball in src - .git stuff Take a look at http://linux.die.net/man/1/git-archive for best practice on how to release a tarball with Git. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review