Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=800930 --- Comment #4 from Martin Erik Werner <martinerikwerner@xxxxxxxxx> 2012-03-07 15:04:14 EST --- Hello, and thanks for reviewing! :) I'm in the process of re-uploading the files, but the srpm will obviously take a while... Changed: 1. Macros in the #Source0 comment to "%%" 2. -x and renamed generate-tarball.sh -> redeclipse-generate-tarball.sh 3. Added redeclipse-server package, in order that the server may be installed without pulling in all of redeclipse-data (which are not required for the server). > You should be using upstream sources and patches, or svn/git snapshot if that > is more appropriate see > http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Package_Versioning I'm not quite sure I follow you here, are you saying some of these patches are inappropriate, if so, which? Or are you saying the patches should be separated out and not extracted from the debian sources? I figured it was the right thing to do since these are patches that won't get applied upstream (I have asked), and since I wrote the patches for Debian initially, it is the upstream for these patches, no? The icon-fix patch is an exception, that one is applied upstream, the header should indicate that, should I be including this a a separate Patch# instead? (I was pulling it in since it already exists in the debian sources) I am not using svn snapshots since the SVN version will become (is?) incompatible with the released version. Maybe there would be reason to do a redeclipse-svn package sometime, but at the moment I do not think there is. Thanks. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review