Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=800294 --- Comment #2 from Matthias Runge <mrunge@xxxxxxxxxxxxxxxxx> 2012-03-07 03:17:35 EST --- Thank you for your review and hints. I corrected the obsolets (good catch), once python-django hits the repos, I'll change the requires. Since Provides: Django should stay there forever, requiring Django won't break, if Django gets renamed to python-django. There are a few minors preventing running tests now. I've asked upstream about this; I've also asked to include a license file. updated SRPM: http://www.matthias-runge.de/fedora/python-django-piston-0.2.3-3.fc16.src.rpm updated SPEC: http://www.matthias-runge.de/fedora/python-django-piston.spec [mrunge@mrungexp SPECS]$ diff -u python-django-piston.spec.2 python-django-piston.spec --- python-django-piston.spec.2 2012-03-07 08:08:01.326176453 +0100 +++ python-django-piston.spec 2012-03-07 08:50:38.666184046 +0100 @@ -1,7 +1,7 @@ %global pkgname django-piston Name: python-django-piston Version: 0.2.3 -Release: 2%{?dist} +Release: 3%{?dist} Summary: A mini-framework for Django for creating RESTful APIs Group: Development/Languages @@ -11,11 +11,14 @@ #md5=8b040d426793cf22ce89543e059cd6e1 BuildArch: noarch -BuildRequires: python2-devel python-setuptools +BuildRequires: python2-devel +BuildRequires: python-setuptools + +# once bug 737293 closed, reqires should be python-django Requires: Django Provides: %{pkgname} = %{version}-%{release} -Obsoletes: %{pkgname} < 0.2.3-1 +Obsoletes: %{pkgname} < 0.2.3-3 %description Piston is a relatively small Django application that lets you @@ -23,20 +26,28 @@ %prep %setup -q -n %{pkgname}-%{version} +rm -rf django_piston.egg-info %build %{__python} setup.py build + %install %{__python} setup.py install -O1 --skip-build --root $RPM_BUILD_ROOT %files %defattr(-,root,root,-) -%doc PKG-INFO -%{python_sitelib}/* +%doc +%{python_sitelib}/piston +%{python_sitelib}/django_piston-%{version}-py2.?.egg-info +%{python_sitelib}/django_piston-%{version}-py2.?-nspkg.pth %changelog +* Wed Mar 07 2012 Matthias Runge <mrunge@xxxxxxxxxxxxxxxxx> - 0.2.3-3 +- more spec cleanup +- correct %%Obsoletes: + * Tue Mar 06 2012 Matthias Runge <mrunge@xxxxxxxxxxxxxxxxx> - 0.2.3-2 - rename to python-django-piston - spec cleanup -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review