Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=781260 --- Comment #12 from Rex Dieter <rdieter@xxxxxxxxxxxx> 2012-03-06 12:33:05 EST --- OK, sorry for the delay. 1. Naming: mostly ok, but subpkg dependencies SHOULD be fully versioned, for example, instead of: Requires: %{name}-iconset use Requires: %{name}-iconset = %{full_version} and in -iconset-oxygen subpkg, Provides: %{name}-iconset = %{full_version} *unless*, you ever intend to provide alternative iconset's provided elsewhere? If so, then best leave off the versioning. 2. macros. SHOULD remove %if "%{_lib}" == "lib64" -DLIB_SUFFIX=64 \ %endif snippet, default %{cmake} macro already includes that. see /etc/rpm/macros.cmake 3. scriptlets. MUST main pkg, iconset-oxygen, iconset-tango are lacking icon-related scriptlets, see http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache 4. qm translation files SHOULD be marked with %lang(locale) tags, but I'm not sure if that's practical here. if you can figure out a way to do that in an easy way, great. if not, don't worry about it. Sources: ok 7daefb3130a475f9260eac069942076e leechcraft-0.5.0.tar.xz Licensing: ok most code is GPLv3+, sprinkled with some LGPLv2+ and GPLv2+, so combined result is indeed GPLv2+ Address items 1-4, and we're looking good. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review