Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=797962 Petr Šabata <psabata@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #4 from Petr Šabata <psabata@xxxxxxxxxx> 2012-03-06 10:16:16 EST --- > FIX: Correct the base package dependency in your devel subpackage to > %{name}%{?_isa} = %{version}-%{release} OK. > FIX: The license of some files is unclear to me, specifically: > - tload.c (no license, copyright only) > - uptime.c (no license, no copyright) > - vmstat.c (no license, copyright only) > - watch.c (no license, copyright only) > - w.c (no license, copyright only) > - ps/stacktrace.c (no license, copyright only) LGPL2+, OK. > Additionally, proc/whattime.c is explicitly said to be public domain. Public domain and LGPL2+ -- does this mean it was relicensed or only the modifications are under LGPL2+? In case of the latter, add 'Public domain' to your License tag before building the package unless you wish to relicense it in Fedora. > Resolve those with upstream. You could also mention Public domain and > Copyright only in your License tag, I suppose -- that would leave just uptime.c > to deal with. I also suggest consulting the Fedora legal list. > NOTE: Since the base package will always be installed, you don't have to > package all the docs again in the devel subpackage. Sort of OK. You don't have to install the licenses either. > TODO: Resolve the rpmlint warnings, if possible. > NOTE: There seems to be testsuite. Could it be utilized? Possibly in the future... OK. > NOTE: Is there a reason to exclude libprocps.pc? Added, OK. -- Approving. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review