Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=755727 --- Comment #4 from Bill Nottingham <notting@xxxxxxxxxx> 2012-03-05 15:24:57 EST --- - Package meets naming and packaging guidelines - *** Description and URL need /farsight/farsteam/ substitutions. - Spec file matches base package name. - OK - Spec has consistent macro usage. - OK - Meets Packaging Guidelines. - OK - License - LGPLv2+ (OK) - License field in spec matches - OK - License file included in package - OK - Spec in American English - OK - Spec is legible. - OK - Sources match upstream md5sum: - OK 409036c07dcd7d8729ff9c84366c8967 telepathy-farstream-0.2.1.tar.gz - Package needs ExcludeArch - N/A - BuildRequires correct - OK - Spec handles locales/find_lang - N/A - Package is code or permissible content. - OK - Doc subpackage needed/used. - N/A - Packages %doc files don't affect runtime. - OK - Headers/static libs in -devel subpackage. - OK - Spec has needed ldconfig in post and postun - OK - .pc files in -devel subpackage/requires pkgconfig - OK - .so files in -devel subpackage. - OK - -devel package Requires: %{name} = %{version}-%{release} -OK - .la files are removed. - OK - Package is a GUI app and has a .desktop file - N/A - Package compiles and builds on at least one arch. - tested x86_64 w/mock - Package has no duplicate files in %files. - OK - Package doesn't own any directories other packages own. -OK - Package owns all the directories it creates. - OK - No rpmlint output. - *** telepathy-farstream.src:37: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 37) - final provides and requires are sane: *** telepathy-farsight & telepathy-farsight-devel provides should likely use %{version}, not be hardcoded. SHOULD Items: - Should build in mock. - tested x86_64 - Should build on all supported archs - didn't test - Should function as described. - didn't test - Should have sane scriptlets. - OK - Should have subpackages require base package with fully versioned depend. - OK - Should have dist tag - OK - Should package latest version - OK Issues: 1. Description and URL need /farsight/farsteam/ substitutions. 2. Spaces & tabs in the spec 3. telepathy-farsight & telepathy-farsight-devel provides should likely use %{version}, not be hardcoded. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review