Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=783071 Michael Scherer <misc@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misc@xxxxxxxx --- Comment #1 from Michael Scherer <misc@xxxxxxxx> 2012-03-05 04:50:56 EST --- Some nitpicking : 1) BuildRequires: tex(tex), tex(latex) would be better on 2 lines 2) sed -i 's/1.46.1/1.46.0/' CMakeLists.txt should be commented, since while I assume the goal is to make it compile with 1.46.0 boost version, that should be pushed upstream ( ie, treated like a patch ). 3) The doc pull the main package, and I am not sure if that's the way it should be ( ie, I can read the doc without the main framework, no, or may wish to propose it for download on a webserver ). 4) not all defattr have been dropped. So for consistency, I would either drop them all, or keep them all ( if you plan to submit for epel 5 ) 5) Source0 do not have a url, and this could be added IMHO ( to ease various future checks ). I will start a more formal review once this have been fixed :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review