Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=798738 Athmane Madjoudj <athmanem@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |athmanem@xxxxxxxxx Blocks| |563471(FE-SECLAB) --- Comment #4 from Athmane Madjoudj <athmanem@xxxxxxxxx> 2012-03-03 06:11:52 EST --- Here's some comments: - Source0 should be point to upstream ie: http://www.andreafabrizi.it/download.php?file=mysqlenum-0.3.tar.gz - Use %{version} macro instead of hard coded version (eg: in Source0) - %{_sysconfdir}/mysqlenum.conf should be marked as %config I added FE-SECLAB blocker since this package is in Security Lab spin wishlist. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review