Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=786587 --- Comment #10 from Matthias Clasen <mclasen@xxxxxxxxxx> 2012-03-02 16:20:57 EST --- package name: ok spec file name: ok packaging guidelines: generally ok; but it would be nice to use the standard gconf macros license: ok license field: ok language: ok readable: ok upstream sources: ok, but the url should be fixed buildable: ok excludearch: ok buildrequires: ok locale handling: ok ldconfig: ok system libs: ok relocatable: ok directory ownership: not ok; you must own /usr/share/nm-applet and /usr/include/libnm-gtk duplicate files: ok file permissions: ok macro use: ok content: ok large docs: ok %doc content: ok static libs: ok devel files: ok devel deps: not ok; libnm-gtk-devel should require libnm-gtk libtool archives: ok gui apps: not ok; currently only the autostart file is validated, the others should be too duplicate files: ok utf8 filenames: ok Summary: a few fixes required -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review