Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=738744 --- Comment #5 from Vít Ondruch <vondruch@xxxxxxxxxx> 2012-03-02 08:01:57 EST --- * F17/Rawhide - I see that you are already using ruby(abi) = 1.9.1, i.e. you are building for Ruby 1.9.3 in F17/Rawhide, in that case, you should follow the new guidelines [1]. BTW I placed .spec file updated according to the new guidelines here [2]. * Tests do not run - There is reported "test/test_execjs.rb: cannot load such file -- multi_json" error. It should be fixed by adding: BuildRequires: rubygem(multi_json) => 1.0 BuildRequires: rubygem(multi_json) < 2 - After adding the BR, it fails anyway with message: "Could not find a JavaScript runtime. See https://github.com/sstephenson/execjs for a list of available runtimes." So there should be BR some supported JS engine (spidermonkey?) or better all engines available in Fedora. [1] https://fedoraproject.org/wiki/PackagingDrafts/Ruby [2] http://people.redhat.com/vondruch/rubygem-execjs.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review