Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=789386 --- Comment #3 from Orcan Ogetbil <oget.fedora@xxxxxxxxx> 2012-02-28 22:04:17 EST --- Thank you for the update. Here is the rest of the review: * Missing BR: swig ! BR: python is redundant. Does no harm though. * BR: boost-devel and glib2-devel are redundant. It would be good to remove them so that we don't have to drag in unrelated packages during a build. ? Could you backport the fixes from the trunk and run the tests? * I am not sure we need to divide the Python modules in two subpackages. At the very least the noarch package should require the arch specific one, since lilv.py has import _lilv referring to _lilv.so. Can _lilv.so be used without lilv.py? If not, they should probably go to the same package (feel free to disagree :)). - rpmlint says: lilv.x86_64: W: non-conffile-in-etc /etc/bash_completion.d/lilv lilv.x86_64: W: no-manual-page-for-binary lilv-bench python-lilv.noarch: W: no-documentation These can be ignored. * /usr/share/man/man3/* should go to the devel package as this is development documentation. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review