Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=783849 Brian Pepple <bdpepple@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #4 from Brian Pepple <bdpepple@xxxxxxxxx> 2012-02-28 17:52:41 EST --- Good: * Source URL is canonical * Upstream source tarball verified * Package name conforms to the Fedora Naming Guidelines * Group Tag is from the official list * All paths begin with macros * All directories are owned by this or other packages * All necessary BuildRequires listed. * Builds fine in mock. * Doesn't contain any .la libtool archives. Minor Non-blockers: * I believe the clean section & the %defattr in the files section are not necessary anymore. * rpmlint errors: ktoblzcheck.x86_64: W: file-not-utf8 /usr/share/doc/ktoblzcheck-1.37/NEWS ktoblzcheck.x86_64: E: incorrect-fsf-address /usr/share/doc/ktoblzcheck-1.37/COPYING ktoblzcheck.x86_64: W: file-not-utf8 /usr/share/doc/ktoblzcheck-1.37/ChangeLog +1 Package Approved. Those rpmlint errors can be corrected when you import the package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review