Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=783268 Brian Pepple <bdpepple@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #3 from Brian Pepple <bdpepple@xxxxxxxxx> 2012-02-28 17:28:46 EST --- Good: * Source URL is canonical * Upstream source tarball verified * Package name conforms to the Fedora Naming Guidelines * Group Tag is from the official list * All paths begin with macros * All directories are owned by this or other packages * All necessary BuildRequires listed. * Builds fine in mock. * Doesn't contain any .la libtool archives. Minor: * rpmlint output on that isn't a blocker: goffice08.x86_64: W: spelling-error Summary(en_US) Goffice -> Office, G office, Goff ice goffice08-devel.x86_64: E: incorrect-fsf-address /usr/include/libgoffice-0.8/goffice/gtk/go-action-combo-color.h goffice08-devel.x86_64: E: incorrect-fsf-address /usr/include/libgoffice-0.8/goffice/component/goffice-component.h goffice08-devel.x86_64: E: incorrect-fsf-address /usr/include/libgoffice-0.8/goffice/gtk/go-calendar-button.h goffice08-devel.x86_64: E: incorrect-fsf-address /usr/include/libgoffice-0.8/goffice/gtk/go-action-combo-pixmaps.h goffice08-devel.x86_64: E: incorrect-fsf-address /usr/include/libgoffice-0.8/goffice/gtk/go-action-combo-stack.h goffice08-devel.x86_64: E: incorrect-fsf-address /usr/include/libgoffice-0.8/goffice/gtk/go-format-sel.h goffice08-devel.x86_64: E: incorrect-fsf-address /usr/include/libgoffice-0.8/goffice/gtk/go-action-combo-text.h Bad: * Fails to build in Rawhide, but it looks like it's due to an issue with the version of PCRE there. I don't consider this a blocker, since it builds fine in F17, and I trust that you'll track down the problem in Rawhide. Here is a link to my rawhide scratch build. https://koji.fedoraproject.org/koji/taskinfo?taskID=3833918 +1 Package Approved. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review