Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=797945 Kevin Fenzi <kevin@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #2 from Kevin Fenzi <kevin@xxxxxxxxx> 2012-02-27 12:38:51 EST --- OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (BSD) OK - License field in spec matches See below - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 3e33f74f12819f4864f4cb051fd07b9f trac-sumfields-plugin-1.0.1.svn10482.tar.gz a1b51aaa80cf173416808995d9b569a5 trac-sumfields-plugin-1.0.1.svn10482.tar.gz.orig (difference is timestamps and other svn stuff, content is the same) OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) See below - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have dist tag OK - Should package latest version OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin Issues: 1. Might ask upstream to include a copy of the License. (not a blocker). 2. rpmlint says: trac-sumfields-plugin.noarch: W: no-documentation trac-sumfields-plugin.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/sumfields/templates/sumfields.html trac-sumfields-plugin.src: W: invalid-url Source0: trac-sumfields-plugin-1.0.1.svn10482.tar.gz Possibly fix the perms on the html file to quiet rpmlint? Others can be ignored. I see no other blockers/issues here, so this package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review