Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717502 Guillermo Gómez <guillermo.gomez@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |MODIFIED Flag|needinfo?(guillermo.gomez@g | |mail.com) | --- Comment #27 from Guillermo Gómez <guillermo.gomez@xxxxxxxxx> 2012-02-26 08:05:27 EST --- Please include rpmlint output for rpm binaries too in the future. MUST: rpmlint must be run on the source rpm and all binary rpms the build produces. The output should be posted in the review. Package Review ============== Key: - = N/A x = Pass ! = Fail ? = Not evaluated ==== C/C++ ==== [x]: MUST Header files in -devel subpackage, if present. [x]: MUST Package does not contain any libtool archives (.la) [x]: MUST Package does not contain kernel modules. [x]: MUST Rpath absent or only used for internal libs. [x]: MUST Package is not relocatable. ==== Generic ==== [x]: MUST Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: MUST Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: MUST All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [!]: MUST Buildroot is not present Note: Buildroot is not needed unless packager plans to package for EPEL5 [x]: MUST Package contains no bundled libraries. [x]: MUST Changelog in prescribed format. [x]: MUST Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: Clean would be needed if support for EPEL is required [x]: MUST Sources contain only permissible code or content. [x]: MUST Each %files section contains %defattr if rpm < 4.4 Note: Note: defattr macros not found. They would be needed for EPEL5 [x]: MUST Package contains a properly installed %{name}.desktop using desktop- file-install file if it is a GUI application. [x]: MUST Permissions on files are set properly. [x]: MUST Package does not contain duplicates in %files. [x]: MUST Spec file lacks Packager, Vendor, PreReq tags. [x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf would be needed if support for EPEL5 is required [x]: MUST If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: MUST License field in the package spec file matches the actual license. [x]: MUST The spec file handles locales properly. [ ]: MUST Package consistently uses macros (instead of hard-coded directory names). [x]: MUST Package meets the Packaging Guidelines. [x]: MUST Package is named according to the Package Naming Guidelines. [x]: MUST Package does not own files or directories owned by other packages. [x]: MUST Package installs properly. [x]: MUST Requires correct, justified where necessary. [!]: MUST Rpmlint output is silent. rpmlint i4uc-0.5.6-9.fc16.x86_64.rpm i4uc.x86_64: W: no-manual-page-for-binary i4uc-gtk 1 packages and 0 specfiles checked; 0 errors, 1 warnings. rpmlint i4uc-debuginfo-0.5.6-9.fc16.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. rpmlint i4uc-0.5.6-9.fc16.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [!]: MUST Sources used to build the package match the upstream source, as provided in the spec URL. /home/gomix/rpmbuild/717502/i4uc-0.5.6.tar.bz2 : MD5SUM this package : 44f9028a5779aea9aa729bd0b6f128cf MD5SUM upstream package : d41d8cd98f00b204e9800998ecf8427e [x]: MUST Spec file is legible and written in American English. [x]: MUST Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: MUST File names are valid UTF-8. [x]: SHOULD Reviewer should test that the package builds in mock. [!]: SHOULD Dist tag is present. [x]: SHOULD SourceX is a working URL. [x]: SHOULD Spec use %global instead of %define. Issues: [!]: MUST Buildroot is not present (not blocking) Note: Buildroot is not needed unless packager plans to package for EPEL5 [!]: MUST Rpmlint output is silent. (not blocking) rpmlint i4uc-0.5.6-9.fc16.x86_64.rpm i4uc.x86_64: W: no-manual-page-for-binary i4uc-gtk 1 packages and 0 specfiles checked; 0 errors, 1 warnings. rpmlint i4uc-debuginfo-0.5.6-9.fc16.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. rpmlint i4uc-0.5.6-9.fc16.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [!]: MUST Sources used to build the package match the upstream source, as provided in the spec URL. /home/gomix/rpmbuild/717502/i4uc-0.5.6.tar.bz2 : MD5SUM this package : 44f9028a5779aea9aa729bd0b6f128cf MD5SUM upstream package : d41d8cd98f00b204e9800998ecf8427e This is a blocker for me, please review this issue carefully and come back for final approval Guillermo -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review