Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=789386 Orcan Ogetbil <oget.fedora@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |oget.fedora@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |oget.fedora@xxxxxxxxx Flag| |fedora-review? --- Comment #1 from Orcan Ogetbil <oget.fedora@xxxxxxxxx> 2012-02-25 22:51:21 EST --- I started reviewing this one. Here are my initial findings: ! The specfile in th link above does not match the specfile that comes inside the SRPM. I started the review with the latter. * Missing BR: lv2core-devel sord-devel (You BR sord instead, which is insufficient). I suggest using mock which will tell you the BRs you need to add. * The directory /etc/bash_completion.d/ remains unowned. We can either own this directory, or add Requires: bash_completion. But looking at the multiple owners of the directory /etc/bash_completion.d/ I can say that we should also own this directory. * You can pass "--bindings" to "./waf configure" to build the Python bindings. Note that you will then also need BR: swig python-devel (Just BR: python is not sufficient) * Fedora specific compilation flags are not honored. You will need to export CFLAGS instead, as the source is written in C. ! Since you build the unit test via --test, you should probably run the test in %check. * %{_mandir}/man1/* should go into the main package, as these are manpages for stuff that goes to /usr/bin. * License tag should be MIT. ! Buildroot tag is no longer required. Does no harm though. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review