[Bug 796465] Review Request: exif - Utility to show EXIF information hidden in JPEG files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=796465

--- Comment #1 from Michael Schwendt <mschwendt@xxxxxxxxx> 2012-02-24 03:34:10 EST ---
> %lang(da) %{_datadir}/locale/da/LC_MESSAGES/%{name}.mo
> %lang(de) %{_datadir}/locale/de/LC_MESSAGES/%{name}.mo
> [...]

| MUST: The spec file MUST handle locales properly. This is done by using the
| %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.

-> https://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files


> License:        GPLv2

That doesn't match the source code files.


> %{_mandir}/man1/%{name}.1.*

Good that '*' is used here to allow for arbitrary compression, but slightly
better would be to not strictly require a file extension:

  %{_mandir}/man1/%{name}.1*


> $ grep SUBD Makefile.am
> SUBDIRS = m4m po libjpeg exif test

Directory "test" contains a test-suite that can be executed as "make check" and
seems to be suitable for a %check section in the spec file.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]