Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=794722 --- Comment #8 from David Nalley <david@xxxxxxx> 2012-02-23 10:02:21 EST --- So actually the version in the file you reference is: 201103-SNAPSHOT That strikes me that as a filler value, and it has remained unchanged over several different revisions. Another thing I just noticed is how you are building the tarball - you are grabbing trunk - not specifying the revision number that you want - which means for each additional revision you'd have no way of knowing what you originally built - this needs to specify a specific revision - and that revision should somehow be referenced. And this specifically is one of the reasons I don't like the above date reference in the pom. Upstream isn't tagging releases (well it has, but that was 5 years ago), and that reference has remained the same for several commits - so it's effectively meaningless - commit 68, 69, and 70 all contain the same version - and you relying on that field doesn't communicate the actual version/status. Specifically thing about: If upstream were to make 2 commits next week and you want to update - what would the version be then (I find it incredibly unlikely that they'd change the value in the pom, since it's gone unchanged.) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review